-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added optional path in --update #538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides this I'll leave couple of comments for the code itself, as I found some bugs.
kept returning:
|
AdnanHodzic
reviewed
Aug 7, 2023
AdnanHodzic
reviewed
Aug 7, 2023
AdnanHodzic
reviewed
Aug 7, 2023
AdnanHodzic
reviewed
Aug 7, 2023
AdnanHodzic
reviewed
Aug 28, 2023
AdnanHodzic
reviewed
Aug 28, 2023
AdnanHodzic
reviewed
Aug 28, 2023
bin/auto-cpufreq
Outdated
if os.path.exists(custom_dir): | ||
os.rmdir(custom_dir) | ||
os.makedirs(custom_dir) | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need line 262 & 263, as this directory would've been created above if it doesn't exist.
LGTM, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in continuation of PR #535
as per your suggestions, an optional add to path has been added.
i.e.
auto-cpufreq --update=path/to/dir
i was expecting to use:
auto-cpufreq --update path/to/dir
but there are some unknown issues